Skip to content

feat(dashmate): verbose connect ENOENT /var/run/docker.sock error - #951

Merged
shuplenkov merged 4 commits into
v0.24-devfrom
feat/dashmate_error_handling
Apr 24, 2023
Merged

feat(dashmate): verbose connect ENOENT /var/run/docker.sock error#951
shuplenkov merged 4 commits into
v0.24-devfrom
feat/dashmate_error_handling

Conversation

@shuplenkov

@shuplenkov shuplenkov commented Apr 20, 2023

Copy link
Copy Markdown

Issue being fixed or feature implemented

If docker socket is not accessible, user sees connect ENOENT /var/run/docker.sock message, which is not clear. We need to provide better description with instructions how to solve this.

What was done?

Handle more errors during system requirements check.

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Apr 20, 2023
Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated
@shumkov shumkov changed the title feat(dashamte): handle connect ENOENT /var/run/docker.sock docker error feat(dashmate): handle connect ENOENT /var/run/docker.sock docker error Apr 24, 2023
@shumkov shumkov changed the title feat(dashmate): handle connect ENOENT /var/run/docker.sock docker error feat(dashmate): verbose connect ENOENT /var/run/docker.sock docker error Apr 24, 2023
@shumkov shumkov changed the title feat(dashmate): verbose connect ENOENT /var/run/docker.sock docker error feat(dashmate): verbose connect ENOENT /var/run/docker.sock error Apr 24, 2023
Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov
shuplenkov merged commit 3d143e1 into v0.24-dev Apr 24, 2023
@shuplenkov
shuplenkov deleted the feat/dashmate_error_handling branch April 24, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants